Interpolate every position aesthetic when munching - #1105
Merged
Conversation
Path munching interpolated `x` and `y` but copied all other columns from each segment's starting point. Position aesthetics such as `ymin` and `ymax` also define geometry, so copying them made transformed ribbon edges step between observations. Interpolate every position aesthetic present in the data so non-linear coordinates preserve ribbons and other interval-based geometry.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 210 210
Lines 14925 14926 +1
Branches 1890 1892 +2
=======================================
+ Hits 13049 13050 +1
Misses 1300 1300
Partials 576 576 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path munching interpolated
xandybut copied all other columns from each segment's starting point. Position aesthetics such asyminandymaxalso define geometry, so copying them made transformed ribbon edges step between observations.Interpolate every position aesthetic present in the data so non-linear coordinates preserve ribbons and other interval-based geometry.