Infra: Migrate test framework from xUnit to NUnit (#71)#73
Closed
Infra: Migrate test framework from xUnit to NUnit (#71)#73
Conversation
- Create Playwright.Nunit project with PlaywrightTestAttribute (PRODUCT env var, IsChromium/IsFirefox/IsWebkit props) - Replace xunit/xunit.runner.visualstudio packages with NUnit 4.1.0, NUnit3TestAdapter 4.6.0, NUnit.Analyzers 4.3.0 - Replace Playwright.Testing.Xunit project reference with Playwright.Nunit - Rewrite base test classes: [SetUp]/[TearDown] instead of IAsyncLifetime, [SetUpFixture] for global setup - Remove ITestOutputHelper constructors, [Collection] attributes, xUnit test framework customization - Convert all test attributes: [Fact] -> [Test], [Fact(Skip=...)] -> [Test, Ignore(...)], [Theory]/[InlineData] -> [TestCase] - Convert all assertions to NUnit constraint model (Assert.That with Is.EqualTo, Does.Contain, etc.) - Convert Assert.ThrowsAsync/ThrowsAnyAsync to NUnit equivalents (ThrowsAsync/CatchAsync) - Delete xUnit infrastructure: PlaywrightSharpBrowserLoaderCollection, PlaywrightXunitTest* classes, XunitLogger, xunit.runner.json - Add [assembly: NonParallelizable] via PlaywrightSharpSetUpFixture - Update SkipBrowserAndPlatformFact to use NUnit's IApplyToTest pattern Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
Will be combined with rename and CI/CD into a single PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Playwright.Nunitproject (net10.0, NUnit 4.1.0) withPlaywrightTestAttributeincludingIsChromium/IsFirefox/IsWebkitproperties driven by PRODUCT env var[SetUp]/[TearDown]/[SetUpFixture]instead of xUnitIAsyncLifetime/ICollectionFixtureITestOutputHelper,[Collection]attributes, converted[Fact]to[Test],[Fact(Skip=...)]to[Test, Ignore(...)],[Theory]/[InlineData]to[TestCase]Assert.ThatwithIs.EqualTo,Does.Contain,Is.True, etc.)[assembly: NonParallelizable]for test execution safetyCloses #71
Test plan
dotnet build ./src/Playwright.slnpasses with 0 errorsdotnet test --list-tests🤖 Generated with Claude Code