Describe Definition of Done for the code changes#1642
Open
Describe Definition of Done for the code changes#1642
Conversation
Performance comparison of head (0d7351f) vs base (266089d) |
Collaborator
|
Thanks! This is very helpful as a checklist. Two things I used to forget — would it make sense to mention them here too?
Or maybe that's too specific and better left for the function implementation workflow? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1642 +/- ##
========================================
Coverage 97.18% 97.18%
========================================
Files 172 172
Lines 14845 14845
Branches 3264 3264
========================================
Hits 14427 14427
Misses 418 418 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
Definition of Done for the code changesto the DEV_DOCS.mdNote
Low Risk
Documentation-only change that adds contribution/process guidance; no runtime behavior or data/security impact.
Overview
Adds a new "Definition of Done" section to
DEV_DOCS.mddescribing what production-code PRs must include before review (code changes incl. i18n packs when relevant, tests expectations for internal vs. external contributors, related docs/migration guide updates, JSDoc/technical docs, changelog entry, and PR description).Written by Cursor Bugbot for commit 0d7351f. This will update automatically on new commits. Configure here.