feat: allow saving and rendering of HTML with relative path images#8177
Merged
ruibaby merged 5 commits intohalo-dev:mainfrom Mar 5, 2026
Merged
feat: allow saving and rendering of HTML with relative path images#8177ruibaby merged 5 commits intohalo-dev:mainfrom
ruibaby merged 5 commits intohalo-dev:mainfrom
Conversation
Preserves relative links in comment service and allows 'img' tags and 'class' attribute on 'code' tags in comment content rendering. Improves flexibility for displaying user-generated content with syntax highlighting and images.
f2c-ci-robot
Bot
added
release-note-none
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8177 +/- ##
============================================
+ Coverage 59.55% 61.07% +1.51%
- Complexity 3812 3991 +179
============================================
Files 677 695 +18
Lines 23248 23766 +518
Branches 1500 1550 +50
============================================
+ Hits 13846 14514 +668
+ Misses 8764 8512 -252
- Partials 638 740 +102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
…port-comment-media
Updated CommentContentConverter tests to mock and verify ExternalLinkProcessor instead of ExternalUrlSupplier. This aligns the tests with recent changes in link processing logic and ensures correct handling of relative and absolute image links.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
在渲染评论 HTML 及保存 HTML 内容时允许包含相对路径的图片。
这是评论支持上传媒体文件的相关 PR。
see halo-dev/plugin-comment-widget#205
Does this PR introduce a user-facing change?