Skip to content

engine: wire LLM TOC builder in cmd/engine (HAL-317) #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hallelx2 merged 1 commit into from
Jun 18, 2026
+11 −1
Merged

engine: wire LLM TOC builder in cmd/engine (HAL-317) #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion cmd/engine/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ func run() error {
"queue_driver", cfg.Queue.Driver,
"llm_driver", cfg.LLM.Driver,
"retrieval_strategy", cfg.Retrieval.Strategy,
"ingest_mode", cfg.Ingest.Mode,
"toc_enabled", cfg.Ingest.TOC.Enabled,
)

// Surface any model with no price-book entry: its cost reads $0, which
Expand Down Expand Up @@ -190,7 +192,15 @@ func run() error {
SummaryAxesMaxTopics: cfg.Ingest.SummaryAxes.MaxTopics,
SummaryAxesMaxEntities: cfg.Ingest.SummaryAxes.MaxEntities,
SummaryAxesMaxNumbers: cfg.Ingest.SummaryAxes.MaxNumbers,
GlobalLLMConcurrency: cfg.Ingest.GlobalLLMConcurrency,
// Wire the LLM TOC builder (cmd/server already does this). Without
// these, Pipeline.TOCEnabled defaults to false, runTOCBuilder never
// runs, documents.toc_tree stays NULL, and the treewalk citation
// title_path (HAL-70) can never resolve on the standalone engine.
TOCEnabled: cfg.Ingest.TOC.Enabled,
TOCModel: cfg.Ingest.TOC.Model,
TOCConcurrency: cfg.Ingest.TOC.Concurrency,
TOCCheckPages: cfg.Ingest.TOC.TOCCheckPages,
GlobalLLMConcurrency: cfg.Ingest.GlobalLLMConcurrency,
Comment on lines +199 to +203

@sourcery-ai sourcery-ai Bot Jun 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Clarify precedence between TOC config flags and Ingest.ModeMinimal behavior to avoid silent no-ops.

These TOC settings are applied regardless of ingest mode, but MINIMAL mode later skips TOC entirely. So a config with TOC.Enabled=true and Ingest.Mode=ModeMinimal is effectively ignored without any signal. Consider either forcing TOCEnabled=false when ModeMinimal is selected, or emitting a warning / error when TOC is configured but incompatible with the ingest mode, so operators get clear feedback instead of a silent no-op.

})
if cfg.Ingest.Mode == ingest.ModeMinimal {
logger.Info("ingest: MINIMAL mode — parse→persist→ready; skipping summarize/HyDE/multi-axis/TOC + table extraction")
Expand Down
Loading