fix out-of-bounds pixel write in do_draw_pixel - #9358
Open
Nashit-h wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9358 +/- ##
==========================================
+ Coverage 69.95% 70.03% +0.08%
==========================================
Files 259 259
Lines 79135 79135
Branches 19286 19286
==========================================
+ Hits 55355 55423 +68
+ Misses 17921 17882 -39
+ Partials 5859 5830 -29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mcourteaux
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do_draw_pixel fills a ceil(zoom) square of pixels starting at (x, y) but never clamps to frame_size, while the load/store handler only gates (x, y) against the frame using the float zoom. A crafted trace with a fractional zoom and a coordinate near the right or bottom edge passes that gate yet writes one row and column past the end of the image and anim buffers, which ASAN flags as a heap-buffer-overflow write. Clamp the fill to frame_size the same way the sibling fill_rect already does; valid-input frames render byte-for-byte identically.
Breaking changes
None.
Checklist