Tutorial text improvements - #9348
Conversation
|
Ugh, nullglob strikes again. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9348 +/- ##
==========================================
- Coverage 70.11% 70.02% -0.09%
==========================================
Files 259 259
Lines 79135 79135
Branches 19286 19286
==========================================
- Hits 55487 55417 -70
- Misses 17880 17899 +19
- Partials 5768 5819 +51 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Unfortunately the OpenMP replacement now reads like a bit of a strawman. Spinning up new threads just to run a single parallel loop is clearly going to be slow. It's not a convincing baseline. |
|
Maybe we want std::for_each with a parallel execution policy? |
This doesn't work because Apple libc++ doesn't have
The |
64d47ce to
0b8ac09
Compare
0b8ac09 to
1e0b3dc
Compare
We already say it's not supported for users in the README, so having it here is contradictory. Occurrences in the Python bindings were plain false since the Makefile doesn't build the Python bindings (let alone tutorials) at all.
1e0b3dc to
df70a20
Compare
See the commit descriptions for the changes I made. A few highlights:
-Ito point to/path/to/include, not/path/to/Halide.h) and some were wrong (e.g. autoscheduler usage)std::threadbecause OpenMP isn't readily available on macOS.Breaking changes
None
Checklist
Stack created with GitHub Stacks CLI • Give Feedback 💬