Reorder image and param checks - #9337
Open
mcourteaux wants to merge 5 commits into
Open
Conversation
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9337 +/- ##
==========================================
- Coverage 69.96% 69.80% -0.16%
==========================================
Files 258 258
Lines 78338 78349 +11
Branches 19066 19068 +2
==========================================
- Hits 54806 54694 -112
- Misses 17844 17846 +2
- Partials 5688 5809 +121 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…fixed here. Move image checks below the user-defined requirements.
…ifier was simplifying it down to "false".
mcourteaux
force-pushed
the
mcourteaux/reorder-image-and-param-checks
branch
from
August 14, 2026 16:04
36d375d to
608d23c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding in a regression test that should have been part of #9333, revealed another issue with the alignment propagation.
When going the
add_requirement()route, those asserts ended up below the ImageChecks asserts. So bounds inference (and thus none of those asserts) were aware of any of the user-specified preconditions.I fixed this by peeling off the existing asserts before placing the injection markers.
Drive-by fix to have the generated string for a failed
add_requirements()to actually print the condition, instead of the to-false-simplified failed condition expression.Fixes #9328 again.
Breaking changes
Not really breaking: but the only test that broke was the one checking error codes under certain artificially constructed scenarios. Because the asserts are reordered, a few of those artificially constructed error scenarios were now failing on a reordered assert that in the original test came later.
Checklist