Skip to content

Reorder image and param checks - #9337

Open
mcourteaux wants to merge 5 commits into
mainfrom
mcourteaux/reorder-image-and-param-checks
Open

Reorder image and param checks#9337
mcourteaux wants to merge 5 commits into
mainfrom
mcourteaux/reorder-image-and-param-checks

Conversation

@mcourteaux

@mcourteaux mcourteaux commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Adding in a regression test that should have been part of #9333, revealed another issue with the alignment propagation.

When going the add_requirement() route, those asserts ended up below the ImageChecks asserts. So bounds inference (and thus none of those asserts) were aware of any of the user-specified preconditions.

I fixed this by peeling off the existing asserts before placing the injection markers.

Drive-by fix to have the generated string for a failed add_requirements() to actually print the condition, instead of the to-false-simplified failed condition expression.

Fixes #9328 again.

Breaking changes

Not really breaking: but the only test that broke was the one checking error codes under certain artificially constructed scenarios. Because the asserts are reordered, a few of those artificially constructed error scenarios were now failing on a reordered assert that in the original test came later.

Checklist

  • Tests added or updated (not required for docs, CI config, or typo fixes)
  • Documentation updated (if public API changed)
  • Python bindings updated (if public API changed)
  • Benchmarks are included here if the change is intended to affect performance.
  • Commits include AI attribution where applicable (see Code of Conduct)

@mcourteaux mcourteaux changed the title Mcourteaux/reorder image and param checks Reorder image and param checks Aug 14, 2026
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.80%. Comparing base (da06573) to head (608d23c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9337      +/-   ##
==========================================
- Coverage   69.96%   69.80%   -0.16%     
==========================================
  Files         258      258              
  Lines       78338    78349      +11     
  Branches    19066    19068       +2     
==========================================
- Hits        54806    54694     -112     
- Misses      17844    17846       +2     
- Partials     5688     5809     +121     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcourteaux
mcourteaux force-pushed the mcourteaux/reorder-image-and-param-checks branch from 36d375d to 608d23c Compare August 14, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add_requirement() fails to transitively infer alignment

1 participant