Detect illegal reorderings in Stage::fuse#9186
Open
stevenraphael wants to merge 1 commit into
Open
Conversation
…ed by: Claude Sonnet 4.6 <no-reply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9186 +/- ##
=======================================
Coverage ? 69.37%
=======================================
Files ? 254
Lines ? 78283
Branches ? 18731
=======================================
Hits ? 54306
Misses ? 18468
Partials ? 5509 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alexreinking
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage::fuse erases an outer dimension from the dim list and combines it with an inner dimension. Since the dimension indices are arbitrary, Stage::fuse essentially reorders the dimensions to be next to each other in the list, but prior to this PR it did not verify that the reordering is safe. For example, Halide should throw an error when compiling this program that swaps the inner and outer RVars: