Make HALIDE_CPP_COMPILER_HAS_FLOAT16 overrideable and numeric#8987
Open
alexreinking wants to merge 1 commit intomainfrom
Open
Make HALIDE_CPP_COMPILER_HAS_FLOAT16 overrideable and numeric#8987alexreinking wants to merge 1 commit intomainfrom
alexreinking wants to merge 1 commit intomainfrom
Conversation
Define HALIDE_CPP_COMPILER_HAS_FLOAT16 as 0 or 1 so callers can override detection and use it in #if guards consistently. Exclude __wasm__ from the Clang _Float16 detection path to avoid enabling _Float16 on wasm targets that advertise fp16 features but do not support the source-language type. Fixes #8986
alexreinking
added
the
release_notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define
HALIDE_CPP_COMPILER_HAS_FLOAT16as 0 or 1 so callers can override detection and use it in#ifguards consistently. Exclude__wasm__from the Clang_Float16detection path to avoid enabling_Float16on wasm targets that advertise fp16 features but do not support the source-language type.Fixes #8986