Work around an LLVM bug in widening casts of loads in wasm#8981
Merged
Work around an LLVM bug in widening casts of loads in wasm#8981
Conversation
Member
Author
|
LLVM bug filed as llvm/llvm-project#184676 |
alexreinking
reviewed
Mar 4, 2026
src/CodeGen_WebAssembly.cpp
Outdated
| // insert a freeze node between the load and the extend, causing a | ||
| // cast<LoadSDNode> assertion failure. Use an optimization fence to | ||
| // prevent the DAG combiner from seeing through to the load. See | ||
| // https://github.com/halide/Halide/issues/8928 |
Member
There was a problem hiding this comment.
Can you also put a reference to the LLVM issue here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8928
Pulls in the optimization_fence helper from #8925