Convert some other local mutators and visitors to mutate_with and visit_with#8894
Convert some other local mutators and visitors to mutate_with and visit_with#8894alexreinking wants to merge 16 commits intomainfrom
Conversation
|
There are some clang-tidy things to fix, but I believe the failures are unrelated. |
60b6c8b to
0f767d3
Compare
0f767d3 to
d4c32b8
Compare
d4c32b8 to
11cb928
Compare
|
As a brief note on pull requests like these where mutators and visitors are getting converted into the lambda version of them: When we go forward with the compiler profiling, we lose the RTTI ability to automatically infer the name of the mutator. So I recommend keeping all of them in at least a function with an equivalent descriptive name (like you did, it seems). |
It would also be okay to add a |
A concurrent complement to #8893
AddAtomicMutex.cpp is a little scary, actually.