Skip to content

HCK-14403: improve logging #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chulanovskyi-bs merged 2 commits into from
Jan 16, 2026
Merged

HCK-14403: improve logging #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baa093b
HCK-14403: improve logging
serhii-filonenko Jan 16, 2026
f210916
HCK-14403: add default external browser port
serhii-filonenko Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions forward_engineering/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
}
]
},
"externalBrowserPort": 8080,
"additionalOptions": [
{
"id": "applyDropStatements",
Expand Down
1 change: 1 addition & 0 deletions reverse_engineering/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@
"value": "connectByExternalBrowser"
}
],
"externalBrowserPort": 8080,
"helpUrl": "https://hackolade.com/help/ConnecttoaSnowflakeinstance.html"
}
5 changes: 3 additions & 2 deletions reverse_engineering/helpers/ssoHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ const snowflakeHelper = require('./snowflakeHelper');
const ssoAuthenticatorError = { message: "Can't get SSO URL. Please, check the SAML settings" };

const getSsoUrlData = async (logger, { host, redirectPort = 8080 }) => {
logger.log('info', `Starting SSO connection...`, 'Connection');
logger.log('info', `Redirect port: ${redirectPort}`, 'Connection');

const account = snowflakeHelper.getAccount(host);
const accessUrl = snowflakeHelper.getAccessUrl(account);
const ssoUrlsData = await axios.post(`${accessUrl}/session/authenticator-request`, {
Expand All @@ -13,8 +16,6 @@ const getSsoUrlData = async (logger, { host, redirectPort = 8080 }) => {
},
});

logger.log('info', `Starting SSO connection...`, 'Connection');

const ssoUrl = _.get(ssoUrlsData, 'data.data.ssoUrl', '');
const proofKey = _.get(ssoUrlsData, 'data.data.proofKey', '');
logger.log('info', `SSO URL: ${ssoUrl}`, 'Connection');
Expand Down