Skip to content

fix: remove Leo Peng from UI/UX leadership (#8540)#8630

Open
nathanjkim-codes wants to merge 1 commit intohackforla:gh-pagesfrom
nathanjkim-codes:fix-8540-remove-leo-peng
Open

fix: remove Leo Peng from UI/UX leadership (#8540)#8630
nathanjkim-codes wants to merge 1 commit intohackforla:gh-pagesfrom
nathanjkim-codes:fix-8540-remove-leo-peng

Conversation

@nathanjkim-codes
Copy link
Copy Markdown
Member

Fixes #8540

What changes did you make?

Removed Leo Peng from the UI/UX leadership section in _data/internal/communities/ui-ux.yml.

Why did you make the changes (we will use this info to test)?

  • To keep the UI/UX Community of Practice leadership information up to date.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied UIUXbefore
Visuals after changes are applied AFTER

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b nathanjkim-codes-fix-8540-remove-leo-peng gh-pages
git pull https://github.com/nathanjkim-codes/website.git fix-8540-remove-leo-peng

@github-actions github-actions Bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 4, 2026
@nathanjkim-codes
Copy link
Copy Markdown
Member Author

I have completed this issue and created the PR. Please let me know if any changes are needed.

@nathanjkim-codes
Copy link
Copy Markdown
Member Author

Hi, just checking in on this PR.

I can make any updates if needed. Thanks.

@viet456 viet456 self-requested a review May 5, 2026 06:28
Copy link
Copy Markdown
Member

@viet456 viet456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All boxes checked off, code checks passed, and images of the changes are provided. Thanks for your contribution Nathan. Approved

@mocodesss mocodesss self-requested a review May 5, 2026 11:22
Copy link
Copy Markdown
Member

@mocodesss mocodesss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job Nathan! This is looking good!

PR NOTES:

Done correctly:

  • The merge from and to branches have been correctly set.
  • The issue has been correctly linked.
  • In the issue, you've correctly assigned yourself.
  • The CodeQL alerts have been correctly checked off.
  • In the issue, you've correctly set the project status.
  • Visuals before/after changes are applied.
  • In the issue, action items have correctly been checked off.

The one thing I would add, as I have gotten this request myself: Make sure that your "Why" in the PR is more comprehensive and offers more context than repeating what is said in the issue. Not something I wont approve over though. Again, great job!

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board May 5, 2026
@nathanjkim-codes
Copy link
Copy Markdown
Member Author

Thnks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Status: PRs ✅ waiting for merge team

Development

Successfully merging this pull request may close these issues.

Update Community of Practice: UI/UX Remove Leo Peng

3 participants