fix: remove Leo Peng from UI/UX leadership (#8540)#8630
fix: remove Leo Peng from UI/UX leadership (#8540)#8630nathanjkim-codes wants to merge 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
I have completed this issue and created the PR. Please let me know if any changes are needed. |
|
Hi, just checking in on this PR. I can make any updates if needed. Thanks. |
viet456
left a comment
There was a problem hiding this comment.
All boxes checked off, code checks passed, and images of the changes are provided. Thanks for your contribution Nathan. Approved
mocodesss
left a comment
There was a problem hiding this comment.
Nice job Nathan! This is looking good!
PR NOTES:
Done correctly:
- The merge from and to branches have been correctly set.
- The issue has been correctly linked.
- In the issue, you've correctly assigned yourself.
- The CodeQL alerts have been correctly checked off.
- In the issue, you've correctly set the project status.
- Visuals before/after changes are applied.
- In the issue, action items have correctly been checked off.
The one thing I would add, as I have gotten this request myself: Make sure that your "Why" in the PR is more comprehensive and offers more context than repeating what is said in the issue. Not something I wont approve over though. Again, great job!
|
Thnks for the review! |
Fixes #8540
What changes did you make?
Removed Leo Peng from the UI/UX leadership section in
_data/internal/communities/ui-ux.yml.Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied