Skip to content

Add guarded publish recovery#18

Merged
roodboi merged 1 commit into
mainfrom
codex/publish-recovery
Jul 11, 2026
Merged

Add guarded publish recovery#18
roodboi merged 1 commit into
mainfrom
codex/publish-recovery

Conversation

@roodboi

@roodboi roodboi commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

What changed

  • add a manual recovery trigger to the trusted-publishing workflow
  • allow that trigger only from the canonical repository's main branch
  • retain the existing exact release-PR checks and PUBLISH environment gate
  • test both authorized release paths

Why

The first standalone 4.1.0 publish failed before trusted publishing was enabled. GitHub reruns use the original workflow revision, so a guarded manual trigger is needed to retry with the corrected OIDC workflow without manufacturing another release PR.

Validation

  • bun run format
  • bun run lint
  • bun test tests/workflow-security.test.ts
  • bun run type-check
  • git diff --check

@roodboi roodboi merged commit 9d6e1c3 into main Jul 11, 2026
4 checks passed
@roodboi roodboi deleted the codex/publish-recovery branch July 11, 2026 00:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f4766bb154

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +22 to +23
(github.event_name == 'workflow_dispatch' &&
github.ref == 'refs/heads/main'))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pin the recovery publish to the failed release

When the failed publish is recovered after main has advanced, this manual path still accepts the latest main checkout and the later bun run release step will publish that current tarball under the still-unpublished package version. That can ship unreleased commits as the recovery version instead of the exact release PR contents; consider requiring and checking out a specific release SHA/version for workflow_dispatch rather than accepting branch head.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant