Fix sporadic error with detection of instantiable subtypes#10204
Open
axeluhl wants to merge 21 commits intogwtproject:mainfrom
Open
Fix sporadic error with detection of instantiable subtypes#10204axeluhl wants to merge 21 commits intogwtproject:mainfrom
axeluhl wants to merge 21 commits intogwtproject:mainfrom
Conversation
…ass still having a chance of instantiability
stderr has [ERROR] 'com.google.gwt.user.rebind.rpc.testcases.client.RecursiveTypeGraphInstantiability.StoredDataMiningReportDTO' has no instantiable subtypes which was the expected result.
niloc132
reviewed
Dec 5, 2025
Member
niloc132
left a comment
niloc132
left a comment
There was a problem hiding this comment.
Also, could you update the title to be about the patch (though still brief), and description to follow the template - including details of "why" the change was made? A trailer at the end can then link to the bug ID, but doesn't require a future reader to go over 50+ comments to understand a standalone patch.
zbynek
changed the title
Collaborator
|
@axeluhl the phrase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the issue for discussions.
This PR contains four tests based on two example type graphs that demonstrate the issue and consistently fail when executed with the
mainversion. They all fail consistently because a class that is the only instantiable subtype of an interface has a cycle across its fields' types leading back to the class or the interface it implements.During checking for instantiable subtypes, the type in question is marked as pending in its
TypeInfoComputed(TIC). Then, when the decision isn't final after thecheckSubtypesinvocation, the TIC is not yet marked as done, and erroneously the TIC is then set toinstantiable==falsewhich is incorrect at that time.The fix leaves a pending subtype pending unless a positive result was found and only updates its TIC regarding any instantiable subtypes. This way, inconsistent decisions about types not being instantiable by the RPC generator can be avoided. Four test cases that fail prior to this fix pass with the fix.
Fixes #10181