Sourcery refactored master branch

[sourcery-ai]

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

[sourcery-ai]

Function rrd_convert refactored with the following changes:

• Replace range(0, x) with range(x) (remove-zero-from-range)
• Replace unused for index with underscore (for-index-underscore)

[sourcery-ai]

Function RRDParser._parse_ds refactored with the following changes:

• Simplify logical expression using De Morgan identities (de-morgan)

[sourcery-ai]

Function RRDParser._parse_rra refactored with the following changes:

• Simplify logical expression using De Morgan identities (de-morgan)

[sourcery-ai]

Function RRDParser.parse refactored with the following changes:

• Replace if statement with if expression (assign-if-exp)

[sourcery-ai]

Function main refactored with the following changes:

• Merge dictionary assignment with declaration (merge-dict-assign)

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.56%.

Quality metrics	Before	After	Change
Complexity	9.73 🙂	9.69 🙂	-0.04 👍
Method Length	74.35 🙂	73.06 🙂	-1.29 👍
Working memory	9.76 🙂	9.57 🙂	-0.19 👍
Quality	57.78% 🙂	58.34% 🙂	0.56% 👍

Other metrics	Before	After	Change
Lines	316	310	-6

Changed files	Quality Before	Quality After	Quality Change
rrd_convert.py	54.46% 🙂	55.25% 🙂	0.79% 👍
rrdinfo-parser.py	61.19% 🙂	61.65% 🙂	0.46% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
rrd_convert.py	rrd_convert	21 😞	220 ⛔	12 😞	34.77% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
rrd_convert.py	read_header	12 🙂	190 😞	10 😞	47.68% 😞	Try splitting into smaller methods. Extract out complex expressions
rrdinfo-parser.py	RRDParser.parse	9 🙂	201 😞	10 😞	49.55% 😞	Try splitting into smaller methods. Extract out complex expressions
rrdinfo-parser.py	RRDParser._parse_ds	11 🙂	89 🙂	12 😞	56.30% 🙂	Extract out complex expressions
rrdinfo-parser.py	RRDParser._parse_rra	11 🙂	89 🙂	11 😞	58.03% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.