Merged
Conversation
cemms1
added
run_chromatic
AnastasiiaBalenko
approved these changes
Mar 5, 2026
Contributor
AnastasiiaBalenko
left a comment
AnastasiiaBalenko
left a comment
There was a problem hiding this comment.
👍 Thanks for spotting it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the
banner:closeevent fromuseDesignableBannerModelas this seems to already be covered inwithCloseableWhy?
There are two
banner:closeevents:dotcom-rendering/dotcom-rendering/src/components/marketing/banners/utils/withCloseable.tsx
Line 28 in 8ea2760
dotcom-rendering/dotcom-rendering/src/components/marketing/banners/designableBanner/v2/useDesignableBannerModel.ts
Line 163 in 8ea2760
When closing the reader revenue banner, the event fires twice. We don't want this behaviour ideally.
This PR addresses this so that only one event is fired when closing the reader revenue banner
Screenshots
The event listener is added when the reader revenue banner appears on the page view. The banner is dismissed and the console logs demonstrate the effect of this in the following screenshots: