add xcust component id to affiliated links#15469
Open
oliverabrahams wants to merge 3 commits intomainfrom
Open
add xcust component id to affiliated links#15469oliverabrahams wants to merge 3 commits intomainfrom
oliverabrahams wants to merge 3 commits intomainfrom
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
arelra
approved these changes
Mar 5, 2026
charleycampbell
approved these changes
Mar 5, 2026
Contributor
charleycampbell
left a comment
charleycampbell
left a comment
There was a problem hiding this comment.
Looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
data-x-cust-component-idto the link elements in filter components.Why?
data-x-cust-component-idrather than tracing up the tree to find the nearest parent with adata-component. This was because the tree crawling would have to happen for every link and it could be quite slow on a page with ~50 links.