fix: npm audit to fix vulns#976
Open
carlosthe19916 wants to merge 1 commit intoguacsec:release/0.4.zfrom
Open
Conversation
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refreshes dependency versions across the client, e2e, and root projects—primarily axios, react-hook-form, @hey-api/openapi-ts, @playwright/test, and jest-environment-jsdom—to resolve npm audit vulnerabilities and aligns the OpenAPI generator config with the newer @hey-api/openapi-ts format options while regenerating lockfiles and env scaffolding. Flow diagram for npm audit fix and dependency alignmentflowchart TD
A[Run npm audit] --> B{Vulnerabilities found?}
B -- Yes --> C[Run npm audit fix]
C --> D[Update dependency versions in package.json files]
D --> E[Regenerate package-lock.json]
E --> F[Align versions with main branch]
F --> G[Update tool configs e.g. openapi-ts postProcess]
G --> H[Run npm ci]
H --> I{Vulnerabilities remaining?}
I -- No --> J[Pipeline passes with 0 vulnerabilities]
I -- Yes --> K[Investigate and apply manual fixes]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The change from separate
format/lintfields topostProcess: ["prettier", "eslint"]in the openapi-ts config relies on the new API; consider confirming that the generated client output and invocation (e.g. any scripts that call it) still behave as expected with this configuration style. - The e2e
@playwright/testdependency was changed from an exact version to a caret range; if deterministic CI runs are important, consider keeping this pinned or using a lockfile strategy that guarantees consistent Playwright versions across environments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The change from separate `format`/`lint` fields to `postProcess: ["prettier", "eslint"]` in the openapi-ts config relies on the new API; consider confirming that the generated client output and invocation (e.g. any scripts that call it) still behave as expected with this configuration style.
- The e2e `@playwright/test` dependency was changed from an exact version to a caret range; if deterministic CI runs are important, consider keeping this pinned or using a lockfile strategy that guarantees consistent Playwright versions across environments.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://redhat.atlassian.net/browse/TC-3978, https://redhat.atlassian.net/browse/TC-3563
npm audit fixThis should give us a fresh
npm ci:Summary by Sourcery
Update dependencies to address security vulnerabilities and align with the main branch versions.
Enhancements:
Build: