fix: missing docker while podman is configured#446
Open
a-oren wants to merge 1 commit intoguacsec:mainfrom
Open
fix: missing docker while podman is configured#446a-oren wants to merge 1 commit intoguacsec:mainfrom
a-oren wants to merge 1 commit intoguacsec:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously,
dockerPodmanInfoused a short-circuit OR (||) to choose between docker and podman suppliers. If the docker supplier threw an error (e.g. docker binary not found), the exception propagated and podman was never tried- even when podman was installed and configured. Wrap the docker supplier call in a try/catch so that when docker isunavailable, execution falls through to the podman supplier instead of failing the entire analysis.
Also fix
getSyftEnvsto usedelimiterfromnode:pathinstead ofthe non-existent
File.pathSeparator.Related issues (if any):
Checklist
Additional information