fix: downgrade p-limit from v5 to v4 for webpack compatibility#444
Merged
ruromero merged 1 commit intoguacsec:mainfrom Mar 30, 2026
Merged
Conversation
p-limit v5 uses Node.js subpath imports (#async_hooks) which webpack cannot resolve, breaking downstream consumers that bundle the client (e.g., the VS Code extension). v4 has an identical API without the subpath imports. Fixes guacsec#443 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ruromero
force-pushed
the
fix/downgrade-p-limit-for-webpack
branch
from
a99cf1a to
01e9ee5
Compare
Strum355
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
p-limitfrom^5.0.0to^4.0.0to fix webpack bundling in downstream consumersp-limitv5 uses Node.js subpath imports (#async_hooks) which webpack cannot resolve, causing:The API is identical between v4 and v5. The only v5 addition is
AsyncResourcewrapping for async context propagation (APM/tracing), which this project does not use.Fixes #443
Test plan
npm test)🤖 Generated with Claude Code