fix: avoid passing empty string argument to skopeo when raw=false

[soul2zimate]

Replace static array construction with ArrayList to conditionally add --raw, --authfile, and --daemon-host flags, preventing an empty string from being passed as a CLI argument.

fixes #379

[qodo-code-review]

Review Summary by Qodo

Avoid passing empty string arguments to skopeo command

🐞 Bug fix

Walkthroughs

Description

• Replace static array construction with ArrayList for conditional flag addition
• Prevent empty strings from being passed as CLI arguments to skopeo
• Simplify command building logic by conditionally adding optional flags
• Improve code maintainability and reduce nested ternary complexity

Diagram

flowchart LR
  A["Static array with ternary operators"] -->|"Refactor"| B["ArrayList with conditional additions"]
  B -->|"Add flags if not empty"| C["--authfile, --daemon-host, --raw"]
  B -->|"Convert to array"| D["Clean command array"]
  D -->|"Execute"| E["skopeo inspect"]

Loading

File Changes

1. src/main/java/io/github/guacsec/trustifyda/image/ImageUtils.java 🐞 Bug fix +22/-37

Refactor skopeo command building to avoid empty strings

• Replaced nested ternary operators and static array construction with ArrayList approach
• Added conditional checks to only include --authfile flag when configPath is not empty
• Added conditional checks to only include --daemon-host flag when daemonHost is not empty
• Added conditional check to only include --raw flag when raw parameter is true
• Simplified image reference formatting logic by moving it outside conditional branches

src/main/java/io/github/guacsec/trustifyda/image/ImageUtils.java

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

ⓘ The new review experience is currently in Beta. Learn more

[soul2zimate]

@ruromero Could you approve this ? Thanks