Skip to content

fix(ci): update unit testing for new findings#2830

Merged
lumjjb merged 1 commit intoguacsec:mainfrom
brandtkeller:fix_unit_tests
Feb 9, 2026
Merged

fix(ci): update unit testing for new findings#2830
lumjjb merged 1 commit intoguacsec:mainfrom
brandtkeller:fix_unit_tests

Conversation

@brandtkeller
Copy link
Copy Markdown
Contributor

Description of the PR

This fixes unit tests failing on main. Currently a query is made to the live OSV.dev api which returns data. It looks like it is returning a new vulnerability since the tests were last updated - this is a quick fix for the new vulnerability. There is certainly merit in looking for another strategy that won't break in the future - this is targeted at restoring the baseline.

No associated issue but I can create one if interested

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@mihaimaruseac mihaimaruseac requested review from lumjjb and pxp928 January 9, 2026 17:23
@lumjjb
Copy link
Copy Markdown
Contributor

lumjjb commented Feb 9, 2026

Failure in integration tests due to another issue addressed by #2843 . Will override merge.

@lumjjb lumjjb merged commit 4973c19 into guacsec:main Feb 9, 2026
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants