A108: OpenTelemetry Custom Per-Call Metric Label#525
Merged
ejona86 merged 4 commits intogrpc:masterfrom Mar 17, 2026
Merged
Conversation
ejona86
commented
Dec 5, 2025
|
|
||
| ### Go | ||
|
|
||
| gRPC Go will add a new API to set and get the custom label value in |
Member
Author
Member
Author
|
CC @ctiller |
markdroth
reviewed
Dec 23, 2025
| * `grpc.client.call.retry_delay` | ||
| * Other per-call instruments, e.g., those added by an LB policy, are encouraged | ||
| to support this label | ||
| * RLS is the only such case today, but is not defined in a gRFC |
Member
There was a problem hiding this comment.
I'd suggest just removing this bullet, since it isn't actually a public API. If we want this label on these metrics, we can figure that out internally.
Member
Author
There was a problem hiding this comment.
Unless there is a strong objection, I'm going to leave it, because "figure it out internally" has not been going well, and I basically need to define nothing here. And the code is OSS and I made all the changes to Java in the same commit.
Without this bullet, I'd also need to say "there are no such cases today" to be clear I'm giving the exhaustive list, but that comment would be incorrect because RLS does exist.
markdroth
reviewed
Dec 23, 2025
Member
Author
|
@markdroth, @easwars, @dfawley, friendly ping for review. |
dfawley
approved these changes
Feb 24, 2026
markdroth
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.