Merged
Conversation
wait_for_confident_result
wait_for_confident_result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
confidence_thresholdparameter defaults toNone, and the docstring states that if it isNonethen the detector's confidence threshold will be used. However, it currently only fetches the detector's confidence threshold if the value forimage_queryis a string - if you pass it anImageQueryobject,confidence_thresholdwill still beNonewhen passed toiq_is_confident, which will then error when trying to doiq.result.confidence >= confidence_threshold.This fixes it so it will always fetch the detector's confidence threshold if the inputted
confidence_thresholdis None.