Switch to edge config models defined in python-sdk#355
Merged
timmarkhuff merged 10 commits intomainfrom Mar 20, 2026
Merged
Conversation
…dge-endpoint into tim/use-sdk-defined-config
…use-sdk-defined-config
timmarkhuff
commented
Mar 20, 2026
| yaml_config = os.environ.get("EDGE_CONFIG", "").strip() | ||
| if yaml_config: | ||
| return _load_config_from_yaml(yaml_config) | ||
| return EdgeEndpointConfig.from_yaml(yaml_str=yaml_config) |
Contributor
Author
There was a problem hiding this comment.
I may need some help testing this part. I need a properly formatted yaml string to test with.
Contributor
Author
There was a problem hiding this comment.
I just tested this end-to-end, and it works fine.
honeytung
approved these changes
Mar 20, 2026
Member
honeytung
left a comment
honeytung
left a comment
There was a problem hiding this comment.
LGTM, make the code more consistent nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the code defining Edge config and instead uses the edge config defined in
python-sdk.This is the first step in allowing the
python-sdkto configure the edge.Related PR: groundlight/python-sdk#413