GHC 9.6+ updates#13
Open
dmjio wants to merge 6 commits intogrin-compiler:masterfrom
Open
Conversation
This fixes the build for GHC-9.6.6 and above. - [x] Imports Control.Monad (mtl modules no longer re-export this) - [x] Update 64-bit primops (some functions in ghc-prim have changed for 64-bit primops) - [x] Adds conditional cabal flag for compiling ext-stg-gc externally
- Adds cabal projects to cabal.project - Disables cabal building C++ by default in cabal.project - Updates some of the wpc-plugin and external-stg-compiler code
- This re-invokes `souffle` (per the README) to get an updated version of the C++ code for use w/ `runGC` / `runSouffle`.
Author
|
Since we've updated It seems to build and do the right thing (checks roots for mark and sweep) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @csabahruska,
In preparation for @mpickering and @alt-romes to release an alpha version of
dapintegration w/ GHC, I'd like to ensure that our work with the haskell-estgi-debugger is building along with the comingdapchanges.This PR updates the
external-stg-interpreter,external-stgandexternal-stg-syntaxto build with GHC 9.6+.Things done:
WordandIntsinceghc-primhad slightly changed (primop tests pass now ✅ )cabal.projectfile was added and it does build with the latestsouffle-haskell-0.4.0.0and a working version offinal-pretty-fexternal-ext-stg-gcand-fexternal-ext-liveness-analysis-- disabled by default in the cabal file - but enabled by default incabal.project) to allow users to build thesoufflegenerated C++ by hand. This simplifies the build, andrunSouffleis able to find theext-stg-gcbinary in$PATH.import Control.Monad, it was decided thatControl.Monadshould no longer be re-exported frommtlmodules.bzip2andzlib.^ these tests should run in CI now
Then in the
haskell-debuggerI'm able to makeext-stg-gcavailable onPATHsorunSoufflewill always be able to find it, when we call theexternal-stg-interpreterfromhaskell-debugger.