Skip to content

Fix distribution warn report keys and log message for Sensi parameters#174

Open
sBouzols wants to merge 1 commit into
mainfrom
fix_log_explicit_naming_filter_and_distribution_types
Open

Fix distribution warn report keys and log message for Sensi parameters#174
sBouzols wants to merge 1 commit into
mainfrom
fix_log_explicit_naming_filter_and_distribution_types

Conversation

@sBouzols
Copy link
Copy Markdown
Contributor

PR Summary

Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
@sBouzols sBouzols requested a review from EtienneLt May 22, 2026 15:07
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 27bc37bc-2a39-4742-abcb-ca30ffa06018

📥 Commits

Reviewing files that changed from the base of the PR and between ee2259b and cdf1f8b.

📒 Files selected for processing (2)
  • src/main/java/org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java
  • src/main/resources/org/gridsuite/sensitivityanalysis/server/reports.properties

📝 Walkthrough

Walkthrough

This PR refactors distribution-type validation error messages in the sensitivity analysis service. Message template keys are updated in the Java service code and corresponding message definitions are changed in the properties file, renaming them for clearer constraint semantics while preserving logic and message structure.

Changes

Distribution-type error message refactoring

Layer / File(s) Summary
Distribution-type error message keys and templates
src/main/java/org/gridsuite/sensitivityanalysis/server/service/SensitivityAnalysisInputBuilderService.java, src/main/resources/org/gridsuite/sensitivityanalysis/server/reports.properties
Service code updates two warning report node message template keys in buildSensitivityVariableSets validation—one for LOAD + PROPORTIONAL_MAXP restriction and one for VENTILATION missing distribution keys—and the properties file redefines those keys with new naming (explicit naming filter, load filter) while retaining message structure and placeholders.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The PR description is empty with no descriptive text provided in the PR body. Add a detailed PR description explaining what changes were made, why they were necessary, and what impact they have on the codebase.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: updating distribution warning report keys and log messages for sensitivity analysis parameters.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant