allow to have a list of temporary limits in line catalog#764
allow to have a list of temporary limits in line catalog#764
Conversation
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
src/main/java/org/gridsuite/modification/server/dto/catalog/TemporaryLimitInfos.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/entities/catalog/LimitsForLineTypeEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/entities/catalog/UndergroundLineTypeEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/entities/catalog/LimitsForLineTypeEntity.java
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/NetworkModificationController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/NetworkModificationController.java
Outdated
Show resolved
Hide resolved
| return ResponseEntity.ok().body(lineTypesCatalogService.getLineTypesWithAreaTemperatureShapeFactors(uuid)); | ||
| } | ||
|
|
||
| @GetMapping(value = "/network-modifications/catalog/line_types/{uuid}/withLimits", produces = MediaType.APPLICATION_JSON_VALUE) |
There was a problem hiding this comment.
From our guidelines :
La typographie des mots, composant un path, doit adopter une convention kebab case plutôt que snake ou camel case : /voltage-levels et non /voltage_levels ou /voltageLevels
| @GetMapping(value = "/network-modifications/catalog/line_types/{uuid}/withLimits", produces = MediaType.APPLICATION_JSON_VALUE) | |
| @GetMapping(value = "/network-modifications/catalog/line_types/{uuid}/with-limits", produces = MediaType.APPLICATION_JSON_VALUE) |
But there are conflicting data in the examples !
There was a problem hiding this comment.
where do you see conflicts ?
There was a problem hiding this comment.
I think it should be better keep it withLimits without "-"
There was a problem hiding this comment.
In the guideline page you have the above texte which asks for kebab case and at the end of the page you have that king of example :
/network-modifications/loadModification
Which don't use kebab case at all.
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
| .linearReactance(this.getLinearReactance()) | ||
| .linearCapacity(this.getLinearCapacity()); | ||
| .id(this.getId()) | ||
| .type(this.getType()) |
| return ResponseEntity.ok().body(lineTypesCatalogService.getLineTypesWithAreaTemperatureShapeFactors(uuid)); | ||
| } | ||
|
|
||
| @GetMapping(value = "/network-modifications/catalog/line_types/{uuid}/withLimits", produces = MediaType.APPLICATION_JSON_VALUE) |
There was a problem hiding this comment.
I think it should be better keep it withLimits without "-"
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
|
3 participants
PR Summary