Fix temporary limits modification type in tabular limit sets#3916
Merged
flomillot merged 7 commits intoMay 19, 2026
Conversation
Respect the modification type provided in the CSV column instead of forcing ADD when the outer modification is not of MODIFY type, and no longer skip temporary limits whose name is empty. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughRemoved ChangesModification-type consolidation and temporary-limits change
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/components/dialogs/network-modifications/limit-sets/limit-sets-tabular-modification-utils.ts`:
- Around line 95-100: The current push into temporaryLimits unconditionally adds
placeholders even when name, value, and acceptableDuration are all empty; change
the logic in limit-sets-tabular-modification-utils so you first compute name =
toModificationOperation(modification[TEMPORARY_LIMIT_NAME + i]), value =
toModificationOperation(modification[TEMPORARY_LIMIT_VALUE + i]), and
acceptableDuration =
toModificationOperation(modification[TEMPORARY_LIMIT_DURATION + i]) and only
push the object into temporaryLimits when at least one of name, value, or
acceptableDuration is non-empty (allowing name to be empty if others exist);
still include modificationType from
modification[TEMPORARY_LIMITS_MODIFICATION_TYPE] when pushing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ec135146-9d4b-4ae0-b61d-977499ef6b56
📒 Files selected for processing (1)
src/components/dialogs/network-modifications/limit-sets/limit-sets-tabular-modification-utils.ts
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
…S_MODIFICATION_TYPE` and remove unused `LIMIT_SETS_MODIFICATION_TYPE` constants Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/utils/field-constants.ts (1)
221-230: Inline comments grouping no longer matches member list.With
ADDinserted above the "Modification types for Tabular modifications" comment andDELETEinserted after the "Modification type for simple form modifications" comment, the categorization comments no longer accurately describe which members belong to each group. Consider re-organizing or updating the comments soADD/DELETEare explicitly classified (tabular vs. simple form), otherwise future readers may be misled about where each value is valid.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/utils/field-constants.ts` around lines 221 - 230, The inline comments for OPERATIONAL_LIMITS_GROUPS_MODIFICATION_TYPE no longer match the grouped members; update the comments or reorder members so each value is explicitly classified. Specifically, edit the block containing OPERATIONAL_LIMITS_GROUPS_MODIFICATION_TYPE and either move the ADD and DELETE declarations into the correct commented sections or change the comment lines to state which of ADD, MODIFY, MODIFY_OR_ADD, REPLACE, DELETE belong to "Tabular modifications" vs "simple form modifications" so the categorization for ADD and DELETE is unambiguous when reading the constant.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/components/utils/field-constants.ts`:
- Around line 221-230: The inline comments for
OPERATIONAL_LIMITS_GROUPS_MODIFICATION_TYPE no longer match the grouped members;
update the comments or reorder members so each value is explicitly classified.
Specifically, edit the block containing
OPERATIONAL_LIMITS_GROUPS_MODIFICATION_TYPE and either move the ADD and DELETE
declarations into the correct commented sections or change the comment lines to
state which of ADD, MODIFY, MODIFY_OR_ADD, REPLACE, DELETE belong to "Tabular
modifications" vs "simple form modifications" so the categorization for ADD and
DELETE is unambiguous when reading the constant.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 84850d89-ab4d-4f34-b315-33a0e65ddeaa
📒 Files selected for processing (4)
src/components/dialogs/limits/limits-pane-utils.tssrc/components/dialogs/network-modifications/limit-sets/limit-sets-tabular-modification-utils.tssrc/components/dialogs/network-modifications/tabular/tabular-modification-utils.tssrc/components/utils/field-constants.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- src/components/dialogs/network-modifications/limit-sets/limit-sets-tabular-modification-utils.ts
Meklo
approved these changes
May 11, 2026
basseche
approved these changes
May 19, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADDwhen the outer modification is not ofMODIFYtype. The modification will be done later in the back end and a log will be added, cf Add pre-checks for temporary limit modifications network-modification#186