Merged
Conversation
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
Mathieu-Deharbe
approved these changes
Feb 13, 2026
| } else { | ||
| errorMessage = 'svgLoadingFail'; | ||
| snackError({ headerId: errorMessage }); | ||
| if (isNodeBuilt(currentNodeRef.current)) { |
Contributor
There was a problem hiding this comment.
OK it works. But I am worried about this solution. Are you sure that this is a good idea to hide ALL errors as long as the node is not built ?
Contributor
Author
There was a problem hiding this comment.
If the node isn’t built, we display 'Node not built' in the error section. Once the node is built or when the user selects another built node we trigger a new fetch to regenerate the diagram, so the node becomes built and the error is shown. And if a node becomes unbuilt while an error exists, that error is outdated anyway
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.