chore(yup): use configureYup method and use yup module imports#179
Conversation
…onfiguration initialization Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
|
Warning Review limit reached
More reviews will be available in 59 minutes and 57 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR centralizes Yup schema configuration and migrates all form validation imports. A new initialization module runs ChangesYup import and configuration migration
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/announcements/add-announcement-form.tsx`:
- Line 23: The import of YUP_REQUIRED from `@gridsuite/commons-ui` is invalid in
this release; update the import in add-announcement-form.tsx (currently at the
top import line and where YUP_REQUIRED is used around line 44) to the actual
module that exports it (e.g., import YUP_REQUIRED from its specific path inside
`@gridsuite/commons-ui/dist/`... or the correct subpath the package provides) or
alternatively upgrade `@gridsuite/commons-ui` to a version that re-exports
YUP_REQUIRED from the package root; ensure you update the import statement
referencing YUP_REQUIRED and any usages in the file to match the new import
location.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cc71b5b3-fdf8-4363-9fff-0f624e192197
📒 Files selected for processing (6)
src/configure-yup-init.tssrc/index.tsxsrc/pages/announcements/add-announcement-form.tsxsrc/pages/groups/modification/group-modification-form.tsxsrc/pages/profiles/modification/profile-modification-dialog.tsxsrc/pages/users/modification/user-modification-form.tsx
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
Signed-off-by: Joris Mancini <joris.mancini_externe@rte-france.com>
|



PR Summary