Implement Sqlite.foldl - #56
Merged
Merged
Conversation
- Implements the `Sqlite.foldl` function - Replaces `Sqlite.getAll` implementation with `foldl`. Uses `Array.Builder` to (hopefully) avoid any performance issues of using immutable arrays for larger query result sets vs. the previous kernel implementation which mutated an array in place - Adds tests to ensure `Sqlite.foldl` works as expected
robinheghan
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45
Sqlite.foldlfunction.Sqlite.getAllimplementation withfoldl. The previous kernel implementation mutated an array in place. This rewrite usesArray.Builderto (hopefully) avoid any performance issues creating an array in Gren vs. Js.foldlworks as expected. Given thatgetAllhas been rewritten to usefoldl, all previous tests that usegetAllare also tests forfoldl, too.