Provide an optional callback to enable adding custom Matcher instances#240
Open
mstred wants to merge 1 commit intogregjacobs:masterfrom
Open
Provide an optional callback to enable adding custom Matcher instances#240mstred wants to merge 1 commit intogregjacobs:masterfrom
mstred wants to merge 1 commit intogregjacobs:masterfrom
Conversation
xmflsct
added a commit
to tooot-app/app
that referenced
this pull request
Nov 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR might solve #169.
It offers a callback function to be defined in Autolinker's options called
applyCustomMatchers, enabling the developer to add customMatcher-based objects to the defaultmatchersarray.The default
applyCustomMatchersimplementation is here declared with the intent to simulate a"noop" function, returning an empty array if a custom implementation is not provided and keeping the current behavior just as it is.
PS.: if merged, this needs to be added to the lib docs in order to be known as a possible solution for custom matcher scenarios.