feat: implement internationalization (GECO-125)#380
Conversation
choffmann
changed the title
# Conflicts: # package.json # pnpm-lock.yaml
lzueva
force-pushed
the
implement-internationalization
branch
from
99b0730 to
33697cb
Compare
choffmann
left a comment
choffmann
left a comment
There was a problem hiding this comment.
The lang="de" key is hardcoded in index.html. Please remove it.
The release Markdown files are not translated. In this case, it makes sense to create separate Markdown files, e.g. v0.1.2.de.md and v0.1.2.en.md
The feature is not yet complete. We need to implement a language switcher before merging this PR.
|
|
||
| void i18next.use(initReactI18next).init({ | ||
| lng: 'de', | ||
| debug: true, |
There was a problem hiding this comment.
Please set debug in production to false
| @@ -129,8 +123,7 @@ function Faq() { | |||
| > | |||
| Hochschule Flensburg | |||
| </a> | |||
| ins Leben gerufen. Nach dem erfolgreichen Abschluss des Forschungsprojekts wird | |||
| die Weiterentwicklung des Systems nun von | |||
| {t('sections.faq.items.behind.answer.beforeProgeek')} | |||
| <a | |||
| href="https://progeek.de/" | |||
| target="_blank" | |||
| @@ -139,7 +132,7 @@ function Faq() { | |||
| > | |||
| PROGEEK | |||
| </a> | |||
There was a problem hiding this comment.
Please do not split sentence at link boundary. Use the <Trans> component with named placeholders like this:
<Trans
i18nKey="sections.faq.items.behind.answer"
components={{ hs: <a href="https://hs-flensburg.de/" .../>, pg: <a href="https://progeek.de/" .../> }}
/>
"Hinter dem Projekt stehen die <hs>Hochschule Flensburg</hs>, <pg>PROGEEK</pg>, …".
There was a problem hiding this comment.
Do not translate Datenschutzerklärung
There was a problem hiding this comment.
The translation files are huge. Please consider namespacing them with the i18next namespace feature
2 participants
close #118