Conversation
406cee5 to
35e7051
Compare
d24f105 to
8c249a1
Compare
f86c2f0 to
300a89e
Compare
antoinevg
approved these changes
Feb 12, 2026
Member
antoinevg
left a comment
There was a problem hiding this comment.
👌 I think this is the elegant solution.
Tested:
hackrf_debug --selftesthackrf_debugread/write registershackrf_transfertx/rx, verify all settings function- SDRAngel tx/rx, all settings, verify all settings function
On:
- HackRF One r4
- Praline r1.0
- HackRF Pro 1.2
martinling
requested changes
Feb 19, 2026
This eliminates unnecessary disable/enable cycles for our half-duplex RFFC5072.
Previously we used "sample rate" to mean a rate that is twice the sample rate in several places in firmware.
Re-lock PLL when re-tuning while enabled
d6499e1 to
a2b2728
Compare
martinling
approved these changes
Feb 23, 2026
mossmann
added a commit
that referenced
this pull request
Apr 1, 2026
This was intended to be removed in #1648. Registers are typically written from within USB ISRs. Updates are meant to happen outside of ISRs.
Member
|
I was just doing some testing with the rad1o badge, and found that sweep mode has been broken there since commit b1bfc24. I don't know the cause yet. |
pull Bot
pushed a commit
to bahdahshin/hackrf
that referenced
this pull request
Apr 23, 2026
This matches the behavior before greatscottgadgets#1648.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a new firmware API for unified control of the radio section with a register interface. Requested configuration changes are written to the active register bank. Settings in the active bank are periodically applied and written to the applied bank. Additional banks for specific operating modes store settings that will be copied to the active bank and then applied when switching to that operating mode. For example, settings in the RX bank are copied and applied when starting RX. This effectively implements most of #906.
This initial implementation replaces the underlying structure without changing function from the perspective of host software. It aims to enable future work:
Additionally, by moving the application of radio configuration changes outside of interrupt handlers, this eliminates a class of concurrency bug that can cause tuning failure or other configuration errors.
Fix #1681
Fix #1683