Changed cycle start and feed hold I2C key characters#6
Open
andrewmarles wants to merge 1 commit intogrblHAL:masterfrom
Open
Changed cycle start and feed hold I2C key characters#6andrewmarles wants to merge 1 commit intogrblHAL:masterfrom
andrewmarles wants to merge 1 commit intogrblHAL:masterfrom
Conversation
…egacy due to conflict with macro6 keycode.
Contributor
|
This is a breaking change, would it be better to assign new trigger characters for the macros? Still breaking but likely less code out in the wild using the macros plugin? Top bit set characters from 160 up is IMO the safest. |
Author
|
Ok, that will work. Very little macro code out there as far as I know :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to modern from legacy due to conflict with macro6 keycode.
As I may have to table this work for some time, I wanted to pass this upstream.