Skip to content

Makefile: target PHP 7.4 (and matrix 8.0-8.5), use phpcs.xml.dist #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rick-lam merged 1 commit into from
May 28, 2026
Merged

Makefile: target PHP 7.4 (and matrix 8.0-8.5), use phpcs.xml.dist #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
SHELL = /bin/sh

DOCKER = $(shell which docker)
PHP_VER := 7.2
PHP_VER := 7.4
IMAGE := graze/php-alpine:${PHP_VER}-test
VOLUME := /srv
DOCKER_RUN_BASE := ${DOCKER} run --rm -t -v $$(pwd):${VOLUME} -w ${VOLUME}
Expand Down Expand Up @@ -41,10 +41,10 @@ test: ## Run the unit and integration testsuites.
test: lint test-unit

lint: ## Run phpcs against the code.
${DOCKER_RUN} vendor/bin/phpcs -p --warning-severity=0 src/ tests/
${DOCKER_RUN} vendor/bin/phpcs --standard=./phpcs.xml.dist -p --warning-severity=0 src/ tests/

lint-fix: ## Run phpcsf and fix possible lint errors.
${DOCKER_RUN} vendor/bin/phpcbf -p src/ tests/
${DOCKER_RUN} vendor/bin/phpcbf --standard=./phpcs.xml.dist -p src/ tests/

test-unit: ## Run the unit testsuite.
${DOCKER_RUN} vendor/bin/phpunit --testsuite unit
Expand All @@ -58,10 +58,13 @@ test-matrix-lowest: ## Test all version, with the lowest version
${MAKE} build-update

test-matrix: ## Run the unit tests against multiple targets.
Comment thread
rick-lam marked this conversation as resolved.
${MAKE} PHP_VER="5.6" build-update test
${MAKE} PHP_VER="7.0" build-update test
${MAKE} PHP_VER="7.1" build-update test
${MAKE} PHP_VER="7.2" build-update test
${MAKE} PHP_VER="7.4" build-update test
${MAKE} PHP_VER="8.0" build-update test
${MAKE} PHP_VER="8.1" build-update test
${MAKE} PHP_VER="8.2" build-update test
${MAKE} PHP_VER="8.3" build-update test
${MAKE} PHP_VER="8.4" build-update test
${MAKE} PHP_VER="8.5" build-update test

test-coverage: ## Run all tests and output coverage to the console.
${DOCKER_RUN} phpdbg7 -qrr vendor/bin/phpunit --coverage-text
Expand Down