fix: include bezier control points in connection hitbox calculation#275
Open
Antamansid wants to merge 1 commit intomainfrom
Open
fix: include bezier control points in connection hitbox calculation#275Antamansid wants to merge 1 commit intomainfrom
Antamansid wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Preview is ready. |
draedful
requested changes
Mar 21, 2026
Collaborator
draedful
left a comment
draedful
left a comment
There was a problem hiding this comment.
Hi, please add e2e tests for the interactivity of bezier links.
I would like to have at least two edge cases:
- the target point is to the right of the source for horizontal graphs
- the target point is above the source for vertical graphs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bezier connections were not selectable by click because their control points were not included in the bounding box.
The RBush spatial tree rejected hits on curved segments that extended beyond the start→end rectangle.
Added a
collectBBoxPoints()hook toBaseConnectionthat subclasses can override to contribute additional points to the bounding box.BlockConnectionoverrides it to include bezier control points and label geometry. The change is fully backward-compatible.