Skip to content

fix: enabled flag got ignored #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjorobekov merged 2 commits into from
Mar 20, 2026
Merged

fix: enabled flag got ignored #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba7d46f
fix: enabled flag got ignored
sjorobekov Mar 19, 2026
99e55f6
fix: add test
sjorobekov Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/openapi-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,10 @@ export function createOpenApiRegistry(config: OpenApiRegistryConfig) {
}

function registerRoutes(routes: AppRoutes, {ctx}: NodeKit): AppRoutes {
if (config.enabled === false) {
return routes;
}

const recognizedMethods: readonly HttpMethod[] = [
'get',
'post',
Expand Down
23 changes: 23 additions & 0 deletions src/tests/openapi-registry.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,29 @@ describe('openapi-registry', () => {
const registeredRoutes = registerRoutes(routes, nodekit);
expect(registeredRoutes).toHaveProperty('MOUNT /api/docs');
});

it('should not add MOUNT route when enabled is false', () => {
const {registerRoutes} = createOpenApiRegistry({
enabled: false,
});

const nodekit = new NodeKit();

const routes = {
'GET /test': {
handler: withContract({
request: {},
response: {content: {200: z.object({})}},
})(async (_req, res) => {
res.sendTyped(200, {});
}),
},
};

const registeredRoutes = registerRoutes(routes, nodekit);
expect(registeredRoutes).not.toHaveProperty('MOUNT /api/docs');
expect(registeredRoutes).toHaveProperty('GET /test');
});
});

describe('registerRoutes', () => {
Expand Down
Loading