Skip to content

fix(dateTime): string parse fallbacks to native Date parser #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ValeraS merged 1 commit into from
Feb 19, 2026
Merged

fix(dateTime): string parse fallbacks to native Date parser #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/dateTime/dateTime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,8 @@ function getTimestamp(
} else if (format === undefined) {
const [dateObject, timezoneOrOffset] = parseDateString(input);
if (Object.keys(dateObject).length === 0) {
return [NaN, NaN];
// fallback to native Date parse
return getTimestamp(new Date(input), timezone, locale, format, fixedOffset);
}
[ts] = getTimestampFromObject(
dateObject,
Expand Down
6 changes: 6 additions & 0 deletions src/parser/parser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ describe('Parser', () => {
expect(date).toEqual(TESTED_DATE_STRING);
});

it('should return DateTime in case of using Date.toString() value', () => {
const nativeDate = new Date('2023-11-06T00:00:00.000Z');
const date = dateTimeParse(nativeDate.toString());
expect(date?.toISOString()).toEqual(nativeDate.toISOString());
});

it('should return DateTime in case of using relative date string', () => {
const date = dateTimeParse('now')?.toISOString();
expect(date).toEqual(new Date().toISOString());
Expand Down
Loading