fix(vscode-language-syntax): Add "text.html.vue" as inline injection target#4144
fix(vscode-language-syntax): Add "text.html.vue" as inline injection target#4144trevor-scheer merged 3 commits intographql:mainfrom
Conversation
vuejs/language-tools#5856 changed the vue grammar scope from "source.vue" to "text.html.vue". This change simply adds the new scope to the list of inline injection targets. Old scope is still supported for backwards compatibility, tho I am unsure if this is necessary.
🦋 Changeset detectedLatest commit: 3c448f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@dimaMachina could you please have a look into this? For some weeks now all my gql code snippets inside .vue files are not highlighted anymore. Would be awesome if we could get functionality back. |
|
Yeah, this is driving me a little crazy. Please merge this |
|
For reference, if it wasn't clear from what everyone has said so far: This extension no longer works with vue, without this change. Newcomers will not be trying to downgrade their vue extension. They will assume this extension simply doesn't work with vue at all. |
|
Anyone has idea how to return graphql syntax highlighting back to vue files? |
|
You can downgrade the vue extension to 3.0.8 until this is merged |
|
3.1.8 works. I tried them all. And after 3.2.0 no one extension works :( |
|
Correct, that's what this PR fixes, when it gets merged. |
|
@jsmnbom can you add a changeset please? Run |
5 participants
vuejs/language-tools#5856 changed the vue grammar scope from "source.vue" to "text.html.vue". This change simply adds the new scope to the list of inline injection targets. Old scope is still supported for backwards compatibility, tho I am unsure if this is necessary.