Add missing cancellation tokens to async stream operations#673
Open
extra2 wants to merge 1 commit intographql-dotnet:masterfrom
Open
Add missing cancellation tokens to async stream operations#673extra2 wants to merge 1 commit intographql-dotnet:masterfrom
extra2 wants to merge 1 commit intographql-dotnet:masterfrom
Conversation
Fixed missing CancellationToken parameters in GraphQLHttpClient.cs: - Pass cancellationToken to ReadAsStreamAsync() on line 180 - Pass cancellationToken to ReadToEndAsync() on line 193 This ensures proper cancellation support throughout the HTTP request pipeline, allowing operations to be cancelled promptly when requested. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
These overloads are only available in .NET core right? I suspect something like this would be needed. #if NET8_0_OR_GREATER
//ReadAsStreamAsync(cancellationToken);
#else
//ReadAsStreamAsync();
#endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed missing CancellationToken parameters in GraphQLHttpClient.cs:
This ensures proper cancellation support throughout the HTTP request pipeline, allowing operations to be cancelled promptly when requested.