Skip to content

putting a lower bound on the charge to avoid negative arg in log10 #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sevmag wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

putting a lower bound on the charge to avoid negative arg in log10 #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/graphnet/models/detector/icecube.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ def _dom_time(self, x: torch.tensor) -> torch.tensor:
return (x - 1.0e04) / 3.0e4

def _charge(self, x: torch.tensor) -> torch.tensor:
return torch.log10(x)
# catch negative charges arising from input perturbation/noise
return torch.log10(1 + torch.clamp(x, min=0.0))

def _rde(self, x: torch.tensor) -> torch.tensor:
return (x - 1.25) / 0.25
Expand Down
3 changes: 2 additions & 1 deletion src/graphnet/models/detector/nubench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ def _t(self, x: torch.tensor) -> torch.tensor:
return x / 10e5

def _charge(self, x: torch.tensor) -> torch.tensor:
return torch.log10(1 + x)
# catch negative charges arising from input perturbation/noise
return torch.log10(1 + torch.clamp(x, min=0.0))


class FlowerS(NuBenchDetector):
Expand Down
Loading