Add IceTop support to I3TruthExtractor#875
Open
RajwolChapagain wants to merge 2 commits intographnet-team:mainfrom
Open
Add IceTop support to I3TruthExtractor#875RajwolChapagain wants to merge 2 commits intographnet-team:mainfrom
RajwolChapagain wants to merge 2 commits intographnet-team:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an ice_top boolean toggle to I3TruthExtractor that enables correct extraction of truth-level information from IceTop frames. Closes #874 .
Changes
Added ice_top parameter to I3TruthExtractor.init
Updated allowed sub-event streams to include ice_top when ice_top=True
Skips _extract_dbang_decay_length and _get_primary_track_energy_and_inelasticity for IceTop frames
Updated _get_primary_particle_interaction_type_and_elasticity to explicitly use "MCPrimary" for IceTop frames
Updated _find_data_type to correctly identify IceTop MC as "corsika"
Updated frame_is_montecarlo and frame_is_noise to use IceTop-specific frame keys when ice_top=True
Testing
Verified that existing in-ice behavior is fully preserved when ice_top=False (default)
Verified that IceTop frames are correctly identified as "corsika" MC and return non-padding truth values when ice_top=True as shown in the screenshot: