DRY GFQL call validation safelist entries#1604
Open
lmeyerov wants to merge 1 commit into
Open
Conversation
f9e49af to
963d3db
Compare
963d3db to
0844aab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
call/validation.pyno longer owns duplicate axis/ring payload validation bodies; it adapts canonicalgraphistry.validate.validate_axispayload errors into GFQL call validator resultsgraphistry.compute.gfql.call.supportRefs #1058.
Axis/ring classification
validate_axis.pyencode_axis.rowsdocumented_axis_rows_payload_error()after preserving exact GFQL list/dict message precheckring_continuous_layout.axisring_continuous_axis_payload_error()withNoneallowedring_categorical_layout.axisring_categorical_axis_payload_error()withNoneallowedSample axis migration:
LOC buckets
graphistry/compute/gfql/call/validation.py1243 -> 1109 LOC (-134)validation.pyandsupport.pyCHANGELOG.mdCompatibility / compiler-plan surface
validate_axis.pybehaviorSource-path fidelity
rows[0],axis[0], andaxis[0].bounds['min']detail paths before remote postValidation
origin/master: function keys equal (51), metadata failures0, sampled validator diffs0, sampled schema-effect diffs0python3 -m pytest -q graphistry/tests/compute/test_gfql_call_validation.py graphistry/tests/compute/test_call_schema_validation.py graphistry/tests/compute/test_call_operations.py graphistry/tests/test_gfql_remote_metadata.py graphistry/tests/test_validate_settings.py->129 passed, 2 skippedpython3 -m pytest -q graphistry/tests/compute/test_astcall_chains.py graphistry/tests/compute/gfql/test_layout_chain_predicate.py graphistry/tests/compute/gfql/layouts/test_call_layout_radial.py graphistry/tests/layout/ring/test_continuous.py graphistry/tests/layout/ring/test_ring_categorical.py graphistry/tests/test_dataset_id_invalidation.py->77 passed, 3 skipped3110 passed, 20 skipped, 230 deselected, 15 xfailedcudaErrorNoDevicebecause cuDF/cupy are installed but no CUDA device is visible; PR CI remains the authoritative full gate./bin/ruff.sh graphistry/compute/gfql/call/validation.py graphistry/compute/gfql/call/support.py graphistry/tests/compute/test_gfql_call_validation.py graphistry/tests/compute/test_call_schema_validation.py graphistry/tests/test_gfql_remote_metadata.py graphistry/tests/test_validate_settings.py-> green./bin/typecheck.sh graphistry/compute/gfql/call/validation.py graphistry/compute/gfql/call/support.py-> greenpython3 -m py_compile graphistry/compute/gfql/call/validation.py graphistry/compute/gfql/call/support.py graphistry/tests/compute/test_gfql_call_validation.py graphistry/tests/compute/test_call_schema_validation.py-> green./bin/test-minimal-lite.sh-> local environment failure only: cuDF/cupy are installed in this shell but no CUDA device is visible, causingcudaErrorNoDevicefailures in GPU/UMAP/text tests. Non-GPU targeted validation is green; PR CI is the authoritative gate.Review
DGX