Skip to content

Favourite locations#449

Open
karussell wants to merge 5 commits intomasterfrom
favourite_locations
Open

Favourite locations#449
karussell wants to merge 5 commits intomasterfrom
favourite_locations

Conversation

@karussell
Copy link
Member

@karussell karussell commented Mar 23, 2026

An attempt to automatically save recent locations to avoid typing. Will be shown only if a location was successfully used in a route for more than once and only if 0 or 1 character is in the input box (to avoid mixing it with the geocoding results). Also this can be easily cleared.

Try it here.

image

@karussell karussell added the enhancement New feature or request label Mar 23, 2026
@Janekdererste
Copy link
Collaborator

the watch icon makes the box bigger. Possibly move it to the right of the headline? Usually, there is some space. Also, at least in the screenshot, the watch icon is darker than the other icons.

I tried the example and I only saw the recentLocation once. When tinkering with the text boxes and typing a little, no recent locations were shown. I guess some state is not working correctly yet?

@karussell
Copy link
Member Author

I'm not entirely happy with the watch icon to be honest. It is a bit lonely there :)
Previously there was "Recent" text in a slightly different font than the rest which looked somehow better, but then we would need translations and so I thought an icon could be better but now ... I'm not sure.

With "move it to the right". You mean on the right side of every entry?

When tinkering with the text boxes and typing a little, no recent locations were shown. I guess some state is not working correctly yet?

Not sure if there is a bug. The problem is probably also/more the "indirect addition logic". An entry only gets counted if you select it in a successful route, but it will show up only if it has a count > 1 and if the input has 0 or 1 character. For more characters it would be required to mix it with the geocoding results which felt somehow ugly/unintuitive.

Maybe we should add a star button (near the x to clear the input) to make addition explicit?

@Janekdererste
Copy link
Collaborator

That could be good, but only if you remember that for the user. I wouldn't want to set a star and then the app forgets about it on the next reload. This would require storing this in the user's browser for the next session?

I find the 'recently' thing quite appealing. As this is something which might be helpful in a single session already. As a user I would be fine if the app only stores my recent items during one session, as we don't provide any login.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants