Fix: add async support to memoize decorator (#356)#358
Open
Kitan-Dara06 wants to merge 1 commit intograntjenks:masterfrom
Open
Fix: add async support to memoize decorator (#356)#358Kitan-Dara06 wants to merge 1 commit intograntjenks:masterfrom
Kitan-Dara06 wants to merge 1 commit intograntjenks:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds asyncio.iscoroutinefunction support to the memoize decorator. Previously, attempting to memoize an async function would result in caching the raw coroutine object and throwing a TypeError: cannot pickle 'coroutine' object.
By checking if the target is a coroutine, we can properly await the result before saving it to the SQLite database. This allows diskcache to be used natively with async frameworks like FastAPI.
Related Issue:
Fixes #356
Testing:
[x] Reproduced the async caching bug locally.
[x] Verified the fix resolves the TypeError.
[x] Passed 251/251 local pytest suite tests (verified no regressions for synchronous functions).