feat(database_observability.postgres): Add adaptive burst window mechanism to query_samples collector#5196
Open
feat(database_observability.postgres): Add adaptive burst window mechanism to query_samples collector#5196
Conversation
gaantunes
changed the title
gaantunes
force-pushed
the
feature/db-o11y-burst
branch
from
d40ab21 to
809d807
Compare
gaantunes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of Pull Request
Pull Request Details
This burst mechanism is designed to capture the active query execution span and wait events more precisely. Whenever we detect an active row, a scrape burst window is opened. The goal is to try to capture the moment when the execution ends as precisely as possible.
The query was changed for improved performance, as
pg_stat_activityis very lightweight (all data is kept by Postgres in memory), butpg_blocking_pidscan add some overhead. We will only call the second if there are any Lock wait types in first scrape.Issue(s) fixed by this Pull Request
Notes to the Reviewer
PR Checklist